Add callback to fetch latest release for a repo#2
Conversation
There was a problem hiding this comment.
@acrollet It's great to see you adding more functionality to the library.
The idea of this module is that it is a lightweight wrapper around [https://github.com/KnpLabs/php-github-api](KnP Lab's github library). They have implemented support for release assets. The composer.json should be updated to so the dependency is ^1.5.1 and then instead of using drupal_http_request() to make this call it should use the library.
I haven't run coder-review over the patch, but other than the issue above I don't see any other issues with the patch. If you fix it and squash the commits it should be an easy merge.
There was a problem hiding this comment.
@skwashd their support does not actually fetch a binary asset (from a private repo) as this code does, the get() method simply returns an object describing a github asset. I looked into adding a fetch method to the library, but it would be a non-trivial addition. c.f. KnpLabs/php-github-api#320
Fix release check Add callback to fetch release asset by ID and store as a managed file. Document how to avoid storing GH password Revert changes to README
2 participants
Adds callbacks to: